Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatar and labels misalignment #22818

Closed
fsiddi opened this issue Feb 8, 2023 · 2 comments · Fixed by #22955
Closed

Avatar and labels misalignment #22818

fsiddi opened this issue Feb 8, 2023 · 2 comments · Fixed by #22955
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.19.0

Comments

@fsiddi
Copy link
Contributor

fsiddi commented Feb 8, 2023

Description

Up to Gitea 1.16, avatar and labels were aligned correctly. Since the refactoring of the Avatar component, styling breaks in element listings (e.g. users, organizations, etc).

This issue is easily fixed by:

  • replacing the vm class with image in the avatar component
  • or adding display: inline-block to the content div next to the avatar

This breaks in other places, such the landing page of a repo.

Screenshots

Gitea 1.16

image

Gitea 1.19

image

Gitea Version

1.19

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

No response

Browser Version

Chrome 109.0.5414.119
@fsiddi fsiddi added type/bug topic/ui Change the appearance of the Gitea UI labels Feb 8, 2023
@lunny lunny added this to the 1.19.0 milestone Feb 9, 2023
@wolfogre
Copy link
Member

Related to #21145. I am not sure if we should add image back.

@silverwind Could you please take a look?

@wxiaoguang
Copy link
Contributor

Another avatar misalignment is here:

image

This was referenced Feb 17, 2023
Closed
Merged
lunny added a commit that referenced this issue Feb 19, 2023
@Zettat123 @lunny
Fix avatar misalignment (#22955)
65fc2d1 
Fix #22818.

|  Before   | After  |
|  ----  | ----  |
| <img
src="https://user-images.githubusercontent.com/15528715/219617504-d86e7a90-d4ac-4a92-bd8a-100dddc693d5.png"
width="200px" /> | <img
src="https://user-images.githubusercontent.com/15528715/219618645-a4045f65-bda6-49ce-a676-f03a9817bb70.png"
width="200px" />|
| <img
src="https://user-images.githubusercontent.com/15528715/219618013-844ef208-853b-44bd-a67c-36e360f0ffa7.png"
width="200px" /> | <img
src="https://user-images.githubusercontent.com/15528715/219618361-cb13c369-852e-47bf-ae30-e429d348823d.png"
width="200px" /> |

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.19.0
4 participants
@lunny @fsiddi @wxiaoguang @wolfogre