Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Issue URL with body isn't marked as noindex/nofollow #19018

Closed
captn3m0 opened this issue Mar 7, 2022 · 1 comment · Fixed by #19023
Closed

New Issue URL with body isn't marked as noindex/nofollow #19018

captn3m0 opened this issue Mar 7, 2022 · 1 comment · Fixed by #19023

Comments

@captn3m0
Copy link

captn3m0 commented Mar 7, 2022 •
edited
Loading

Gitea Version

1.16.3

Git Version

2.30.2

Operating System

ArchLinux

How are you running Gitea?

Running the latest docker container, using the configuration here: https://git.captnemo.in/nemo/nebula/src/branch/master/gitea

Database

SQLite

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

Access logs showing the URL being hit by bots.

https://www.toptal.com/developers/hastebin/raw/wisiqikasi

Description

While going through the Google Search console against my website, I noticed a lot of URLs that should ideally be marked by Gitea as nofollow noindex but aren't.

I went through both the source and the Google results, but was unable to find where these URLs are getting picked up from.

The URLs are of the format: /:org/:repo/issues/new?body=https://example.com/:org/:repo/src/commit/:commit/:path.

Google is not indexing these currently because these are marked as "Page with redirect" (Gitea redirects Google to a login page), but ideally these should be marked as noindex nofollow so that Google doesn't try to follow the redirect in the first place.

Screenshots

Screenshot of the Google Search Console.
@captn3m0
Copy link
Author

captn3m0 commented Mar 7, 2022

How to validate the issue:

  • Run a publicly accessible gitea website
  • Search your access logs for /issues/new?body=

zeripath added a commit to zeripath/gitea that referenced this issue Mar 7, 2022
@zeripath
Set rel="nofollow noindex" on new issue links
c562c0d 
Fix go-gitea#19018

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Mar 7, 2022
Merged
techknowlogick pushed a commit that referenced this issue Mar 7, 2022
@zeripath
Set rel="nofollow noindex" on new issue links (#19023)
78b38a5 
Fix #19018

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit to zeripath/gitea that referenced this issue Mar 9, 2022
@zeripath
Set rel="nofollow noindex" on new issue links (go-gitea#19023)
656e599 
Backport go-gitea#19023

Fix go-gitea#19018

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Mar 9, 2022
Merged
zeripath added a commit that referenced this issue Mar 9, 2022
@zeripath
Set rel="nofollow noindex" on new issue links (#19023) (#19042)
03d9242 
Backport #19023

Fix #19018

Signed-off-by: Andrew Thornton <art27@cantab.net>
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@zeripath
Set rel="nofollow noindex" on new issue links (go-gitea#19023)
5463668 
Fix go-gitea#19018

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set rel="nofollow noindex" on new issue links zeripath/gitea
1 participant
@captn3m0