Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird comment field rendering on commenting source code #18391

Closed
confusedsushi opened this issue Jan 24, 2022 · 7 comments · Fixed by #18403
Closed

Weird comment field rendering on commenting source code #18391

confusedsushi opened this issue Jan 24, 2022 · 7 comments · Fixed by #18403
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.16.0

Comments

@confusedsushi
Copy link
Contributor

Gitea Version

1.16.0-rc1

Git Version

No response

Operating System

No response

How are you running Gitea?

Pre-built Windows binary.

Database

SQLite

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Description

In a pull request, when looking at a changed file in split view, adding a comment to a line of code renders the comment field weird.

Screenshots

No response
@lafriks
Copy link
Member

lafriks commented Jan 24, 2022

can you add screenshot?

@confusedsushi
Copy link
Contributor Author

image

@lafriks lafriks added type/bug topic/ui Change the appearance of the Gitea UI labels Jan 24, 2022
@lafriks lafriks added this to the 1.16.0 milestone Jan 24, 2022
@mappu
Copy link
Contributor

mappu commented Jan 25, 2022

Probable duplicate of #18320 ?

@lunny
Copy link
Member

lunny commented Jan 25, 2022

Please clear the browser cache and try again.

@confusedsushi
Copy link
Contributor Author

Please clear the browser cache and try again.

Already done. Did not solve the problem.

@confusedsushi
Copy link
Contributor Author

Probable duplicate of #18320 ?

Not a duplicate. But kind of the same problem. In #18320 a similar issue was solved for the unified view. Here the problem is about the split view.

Here it seems an colspan="3" is missing from that one table cell, too.

@zeripath
Copy link
Contributor

zeripath commented Jan 25, 2022 •
edited
Loading

yup - almost certainly.

Fancy putting up the PR to fix? Too late I've put one up.

zeripath added a commit to zeripath/gitea that referenced this issue Jan 25, 2022
@zeripath
Place inline diff comment dialogs on split diff in 4th and 8th columns
0a19b45 
Fix go-gitea#18391
Fix go-gitea#18320

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Jan 25, 2022
Merged
zeripath added a commit to zeripath/gitea that referenced this issue Jan 25, 2022
@zeripath
Place inline diff comment dialogs on split diff in 4th and 8th columns
b7d627e 
(go-gitea#18403)

Backport go-gitea#18403

Fix go-gitea#18391
Fix go-gitea#18320

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Jan 25, 2022
Merged
zeripath added a commit that referenced this issue Jan 25, 2022
@zeripath
Place inline diff comment dialogs on split diff in 4th and 8th columns (
93250bf 
#18403)

Fix #18391
Fix #18320

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit that referenced this issue Jan 25, 2022
@zeripath
Place inline diff comment dialogs on split diff in 4th and 8th columns (
0b331e2 
#18403)  (#18404)

Backport #18403

Fix #18391
Fix #18320

Signed-off-by: Andrew Thornton <art27@cantab.net>
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@zeripath
Place inline diff comment dialogs on split diff in 4th and 8th columns (
f0d82c4 
go-gitea#18403)

Fix go-gitea#18391
Fix go-gitea#18320

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.16.0
Development

Successfully merging a pull request may close this issue.

Place inline diff comment dialogs on split diff in 4th and 8th columns zeripath/gitea
5 participants
@lunny @lafriks @zeripath @mappu @confusedsushi