Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect font size for PR/issue comment #17480

Closed
proton-ab opened this issue Oct 29, 2021 · 2 comments · Fixed by #17582
Closed

Incorrect font size for PR/issue comment #17480

proton-ab opened this issue Oct 29, 2021 · 2 comments · Fixed by #17582
Labels
topic/ui Change the appearance of the Gitea UI
Milestone

Comments

@proton-ab
Copy link
Contributor

Gitea Version

f46e67b

Git Version

No response

Operating System

No response

How are you running Gitea?

Docker image gitea/gitea:dev-rootless

Database

No response

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Description

Font size for PR/issue comment is incorrect. It is using 16px inherited from .markdown class when it should be using its own overridden 14px. The issue occurred between 58cd55d (known good) and 2b2eb5d (known bad) but since half the commits have broken CI run I can't really test them properly without setting up full development environment.

See this try page for example: https://try.gitea.io/ChristopherHX/actions-on-gitea/pulls/2

On v1.15.6 this is handled by (generated code):

.repository.view.issue .comment-list .comment .content .markup {
    font-size: 14px
}

On broken version we can see this instead:

.repository.view.issue .comment-list .comment>.merge-section .markup {
    font-size: 14px
}

Screenshots

Bad (current):
firefox_2021-10-29_02-44-35

Good (simulated):
firefox_2021-10-29_02-44-57

@proton-ab
Copy link
Contributor Author

In addition it seems that the button Update branch by ... has lost its styling too (should be right of the text, not below it).
firefox_2021-10-29_02-54-02

Gusted pushed a commit to Gusted/gitea that referenced this issue Nov 7, 2021
- Fixes a issue that started from
go-gitea#17317
- Move `> .merge-section` to the `> .content` scope.
- Resolves go-gitea#17480
@Gusted
Copy link
Contributor

Gusted commented Nov 7, 2021

Hi @proton-ab!

Thanks for reporting the issue, it will be fixed by #17582.

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Nov 8, 2021
lunny added a commit that referenced this issue Nov 9, 2021
* Move `> .merge-section` to `> .content` scope

- Fixes a issue that started from
#17317
- Move `> .merge-section` to the `> .content` scope.
- Resolves #17480

* Move `.merge-section` back to outside scope

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@lunny lunny added this to the 1.16.0 milestone Nov 9, 2021
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
* Move `> .merge-section` to `> .content` scope

- Fixes a issue that started from
go-gitea#17317
- Move `> .merge-section` to the `> .content` scope.
- Resolves go-gitea#17480

* Move `.merge-section` back to outside scope

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants