Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc errata #15419

Closed
Hokwang opened this issue Apr 12, 2021 · 2 comments
Closed

doc errata #15419

Hokwang opened this issue Apr 12, 2021 · 2 comments
Labels
reviewed/wontfix The problem described in this issue/fixed in this pull request is not a problem we will fix type/docs This PR mainly updates/creates documentation

Comments

@Hokwang
Copy link

Hokwang commented Apr 12, 2021

Hi,

I think I find some problem in your web-site.

  1. please look at https://docs.gitea.io/en-us/config-cheat-sheet/#oauth2-oauth2/
    there's
oauth2:
  ENABLE: true

but, I think ENABLED (add D) may be right. please make consistency with other's.

  1. please look at https://docs.gitea.io/en-us/config-cheat-sheet/#openid-openid
    I think
    ENABLE_OPENID_SIGNUP: ! DISABLE_REGISTRATION: Allow registering via OpenID.
    has problem.
@noerw noerw added the type/docs This PR mainly updates/creates documentation label May 13, 2021
@lunny
Copy link
Member

lunny commented Jun 5, 2021

@Hokwang Could you send a PR?

@noerw
Copy link
Member

noerw commented Jul 10, 2021

Ad 1: the docs are correct, the setting is named ENABLE. This is inconsistent with other ENABLED settings, but due to already high complexity in settings parsing, this is most likely a wontfix

Ad 2: this is also correct, although ENABLE_OPENID_SIGNIN obviously needs to be true too.

@noerw noerw closed this as completed Jul 10, 2021
@noerw noerw added the reviewed/wontfix The problem described in this issue/fixed in this pull request is not a problem we will fix label Jul 10, 2021
noerw added a commit to noerw/gitea that referenced this issue Jul 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
reviewed/wontfix The problem described in this issue/fixed in this pull request is not a problem we will fix type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

No branches or pull requests

3 participants