Skip to content

Commit

Permalink
Fix commits table regression (#25710)
Browse files Browse the repository at this point in the history
Fixes #25693

The commits table appearance fix in #25634 was incomplete and caused a
regression. This PR fixes that issue and removes some unneeded CSS
classes because of the proper fix.

<details>
<summary>Before</summary>

![Bildschirmfoto vom 2023-07-05
19-37-04](https://github.com/go-gitea/gitea/assets/47871822/4f680878-9612-443b-a0a3-b331369c912b)
![Bildschirmfoto vom 2023-07-05
19-38-56](https://github.com/go-gitea/gitea/assets/47871822/8826f246-6bde-4c33-9d10-172d11619908)

</details>

<details>
<summary>After</summary>

![Bildschirmfoto vom 2023-07-05
19-37-44](https://github.com/go-gitea/gitea/assets/47871822/0fe2d2cb-f706-41e0-b341-d1827a64b21a)
![Bildschirmfoto vom 2023-07-05
19-38-08](https://github.com/go-gitea/gitea/assets/47871822/2f29271c-7da5-44d7-bd9a-38a4bfdde219)

</details>

---------

Co-authored-by: silverwind <me@silverwind.io>
  • Loading branch information
denyskon and silverwind committed Jul 6, 2023
1 parent 2af30f7 commit 753755b
Showing 1 changed file with 3 additions and 14 deletions.
17 changes: 3 additions & 14 deletions web_src/css/repo.css
Original file line number Diff line number Diff line change
Expand Up @@ -1313,10 +1313,9 @@
padding: 5px 10px;
}

.repository #commits-table thead th:first-of-type {
padding-left: 15px;
.repository #commits-table td:not(.message) {
white-space: nowrap;
}

.repository #commits-table thead .sha {
width: 200px;
}
Expand Down Expand Up @@ -2684,6 +2683,7 @@ tbody.commit-list {
/* in the commit list, messages can wrap so we can use inline */
.commit-list .message-wrapper {
display: inline;
overflow-wrap: anywhere;
}

/* but in the repo-files-table we cannot */
Expand Down Expand Up @@ -3244,17 +3244,6 @@ tbody.commit-list {
.commit-table th.sha {
display: none !important;
}
.commit-table .commit-list span.message-wrapper {
max-width: none;
}
.commit-table .commit-list tr td:first-child,
.commit-table .commit-list tr td:last-child {
white-space: nowrap;
}
.commit-table .commit-list td.author {
display: block;
width: calc(100% + 0.5rem);
}
.commit-table .commit-list .copy-commit-sha {
display: none !important;
}
Expand Down

0 comments on commit 753755b

Please sign in to comment.