Skip to content

Commit

Permalink
Fix height for sticky head on large screen on PR page (#23111) (#23123)
Browse files Browse the repository at this point in the history
Backport #23111

Right now on the PR 'File Change' Tab, the file title header sticky to
the top on large screens has wrong height, resulting in wrong ui
behavior when scrolling down. This PR is to fix this.

Before:

<img width="964" alt="截屏2023-02-24 17 12 29"
src="https://user-images.githubusercontent.com/17645053/221140409-025c4a84-6bbe-4b5b-a13f-bd2b79063522.png">

After:
<img width="1430" alt="截屏2023-02-24 21 10 12"
src="https://user-images.githubusercontent.com/17645053/221186750-0344d652-4610-4a90-a4c0-7f6269f950d6.png">

Co-authored-by: HesterG <hestergong@gmail.com>
  • Loading branch information
yardenshoham and HesterG committed Feb 24, 2023
1 parent 27e3071 commit 5beb29a
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions web_src/less/_repository.less
Original file line number Diff line number Diff line change
Expand Up @@ -3269,17 +3269,9 @@ td.blob-excerpt {
.ui.attached.header.diff-file-header {
&.sticky-2nd-row {
position: sticky;
top: 46px;
top: 77px;
z-index: 7;

@media @mediaMd {
top: 77px;
}

@media @mediaSm {
top: 77px;
}


@media (max-width: 480px) {
position: static;
}
Expand Down

0 comments on commit 5beb29a

Please sign in to comment.