Skip to content

Commit

Permalink
Adds checking of reserved keywords against team names (#22)
Browse files Browse the repository at this point in the history
  • Loading branch information
LefsFlare authored and strk committed Nov 6, 2016
1 parent fe8bfa5 commit 55a4d46
Showing 1 changed file with 17 additions and 1 deletion.
18 changes: 17 additions & 1 deletion models/org_team.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,13 +194,29 @@ func (t *Team) RemoveRepository(repoID int64) error {
return sess.Commit()
}

func IsUsableTeamName(name string) (err error) {
var reservedTeamNames = []string{"new"}

for i := range reservedTeamNames {
if name == reservedTeamNames[i] {
return ErrNameReserved{name}
}
}

return nil
}

// NewTeam creates a record of new team.
// It's caller's responsibility to assign organization ID.
func NewTeam(t *Team) error {
func NewTeam(t *Team) (err error) {
if len(t.Name) == 0 {
return errors.New("empty team name")
}

if err = IsUsableTeamName(t.Name); err != nil {
return err
}

has, err := x.Id(t.OrgID).Get(new(User))
if err != nil {
return err
Expand Down

0 comments on commit 55a4d46

Please sign in to comment.