Skip to content

Commit

Permalink
Added GetUserByIDCtx.
Browse files Browse the repository at this point in the history
  • Loading branch information
KN4CK3R committed Nov 9, 2021
1 parent bb71cee commit 252c75e
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
4 changes: 2 additions & 2 deletions models/issue_comment.go
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ func (c *Comment) LoadAssigneeUserAndTeam() error {
var err error

if c.AssigneeID > 0 && c.Assignee == nil {
c.Assignee, err = getUserByID(db.GetEngine(db.DefaultContext), c.AssigneeID)
c.Assignee, err = GetUserByIDCtx(db.DefaultContext, c.AssigneeID)
if err != nil {
if !IsErrUserNotExist(err) {
return err
Expand Down Expand Up @@ -523,7 +523,7 @@ func (c *Comment) LoadResolveDoer() (err error) {
if c.ResolveDoerID == 0 || c.Type != CommentTypeCode {
return nil
}
c.ResolveDoer, err = getUserByID(db.GetEngine(db.DefaultContext), c.ResolveDoerID)
c.ResolveDoer, err = GetUserByIDCtx(db.DefaultContext, c.ResolveDoerID)
if err != nil {
if IsErrUserNotExist(err) {
c.ResolveDoer = NewGhostUser()
Expand Down
2 changes: 1 addition & 1 deletion models/issue_reaction.go
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ func (r *Reaction) LoadUser() (*User, error) {
if r.User != nil {
return r.User, nil
}
user, err := getUserByID(db.GetEngine(db.DefaultContext), r.UserID)
user, err := GetUserByIDCtx(db.DefaultContext, r.UserID)
if err != nil {
return nil, err
}
Expand Down
9 changes: 7 additions & 2 deletions models/user.go
Original file line number Diff line number Diff line change
Expand Up @@ -1384,7 +1384,12 @@ func getUserByID(e db.Engine, id int64) (*User, error) {

// GetUserByID returns the user object by given ID if exists.
func GetUserByID(id int64) (*User, error) {
return getUserByID(db.GetEngine(db.DefaultContext), id)
return GetUserByIDCtx(db.DefaultContext, id)
}

// GetUserByIDCtx returns the user object by given ID if exists.
func GetUserByIDCtx(ctx context.Context, id int64) (*User, error) {
return getUserByID(db.GetEngine(ctx), id)
}

// GetUserByName returns user by given name.
Expand Down Expand Up @@ -1569,7 +1574,7 @@ func GetUserByEmailContext(ctx context.Context, email string) (*User, error) {
return nil, err
}
if has {
return getUserByID(db.GetEngine(ctx), emailAddress.UID)
return GetUserByIDCtx(ctx, emailAddress.UID)
}

// Finally, if email address is the protected email address:
Expand Down

0 comments on commit 252c75e

Please sign in to comment.