make sure units of a team are returned (#6379) (#6381)

go-gitea · Mar 19, 2019 · 1681530 · 1681530
1 parent 3934d9c
commit 1681530
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/models/org_team.go b/models/org_team.go
@@ -33,6 +33,11 @@ type Team struct {
 	Units       []*TeamUnit `xorm:"-"`
 }
 
+// GetUnits return a list of available units for a team
+func (t *Team) GetUnits() error {
+	return t.getUnits(x)
+}
+
 func (t *Team) getUnits(e Engine) (err error) {
 	if t.Units != nil {
 		return nil

diff --git a/routers/api/v1/org/team.go b/routers/api/v1/org/team.go
@@ -38,6 +38,11 @@ func ListTeams(ctx *context.APIContext) {
 
 	apiTeams := make([]*api.Team, len(org.Teams))
 	for i := range org.Teams {
+		if err := org.Teams[i].GetUnits(); err != nil {
+			ctx.Error(500, "GetUnits", err)
+			return
+		}
+
 		apiTeams[i] = convert.ToTeam(org.Teams[i])
 	}
 	ctx.JSON(200, apiTeams)