This repository has been archived by the owner on Apr 12, 2019. It is now read-only.
Migrate to go mod #134
Closed
Migrate to go mod #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=======================================
Coverage 33.76% 33.76%
=======================================
Files 28 28
Lines 1833 1833
=======================================
Hits 619 619
Misses 1134 1134
Partials 80 80Continue to review full report at Codecov.
|
|
I'm fine with removing vendor folder for this lib |
|
@lafriks done 😄 |
sapk
force-pushed
the
go-mod
branch
8 times, most recently
from
ef9f2d8
to
880bf45
Compare
|
go-gitea/gitea#6364 will replace this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrate from dep to go mod command to manage deps.
I would also propose to remove the vendor folder since this package is a lib and the deps are already vendored in gitea.