Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goversion: add 1.23 to supported versions, update test matrix #3780

Merged
merged 1 commit into from
Jul 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .teamcity/settings.kts
Original file line number Diff line number Diff line change
Expand Up @@ -41,25 +41,25 @@ To debug in IntelliJ Idea, open the 'Maven Projects' tool window (View
version = "2023.05"

val targets = arrayOf(
"linux/amd64/1.20",
"linux/amd64/1.21",
"linux/amd64/1.22",
"linux/amd64/1.23"
"linux/amd64/tip",

"linux/386/1.22",
"linux/386/1.23",

"linux/arm64/1.22",
"linux/arm64/1.23",
"linux/arm64/tip",

"linux/ppc64le/1.22",
"linux/ppc64le/1.23",

"windows/amd64/1.22",
"windows/amd64/1.23",
"windows/amd64/tip",

"mac/amd64/1.22",
"mac/amd64/1.23",
"mac/amd64/tip",

"mac/arm64/1.22",
"mac/arm64/1.23",
"mac/arm64/tip"
)

Expand Down
4 changes: 2 additions & 2 deletions pkg/goversion/compat.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ import (

var (
MinSupportedVersionOfGoMajor = 1
MinSupportedVersionOfGoMinor = 19
MinSupportedVersionOfGoMinor = 21
MaxSupportedVersionOfGoMajor = 1
MaxSupportedVersionOfGoMinor = 22
MaxSupportedVersionOfGoMinor = 23
goTooOldErr = fmt.Sprintf("Go version %%s is too old for this version of Delve (minimum supported version %d.%d, suppress this error with --check-go-version=false)", MinSupportedVersionOfGoMajor, MinSupportedVersionOfGoMinor)
goTooOldWarn = fmt.Sprintf("WARNING: undefined behavior - Go version %%s is too old for this version of Delve (minimum supported version %d.%d)", MinSupportedVersionOfGoMajor, MinSupportedVersionOfGoMinor)
dlvTooOldErr = fmt.Sprintf("Version of Delve is too old for Go version %%s (maximum supported version %d.%d, suppress this error with --check-go-version=false)", MaxSupportedVersionOfGoMajor, MaxSupportedVersionOfGoMinor)
Expand Down