Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: remove redundant lines at the start/end of block #3773

Merged
merged 1 commit into from
Jul 11, 2024
Merged

*: remove redundant lines at the start/end of block #3773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/internal/gosym/symtab.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ func (T *Table) GetInlineTree(f *Func, goFuncVal, baseaddr uint64, progReader io
//goFuncValue := FuncSymName(strver)
//return T.go12line.InlineTree(f,goFuncValue,baseaddr,progReader)
return T.go12line.InlineTree(f, goFuncVal, baseaddr, progReader)

}
func ProgContaining(elfFile *elf.File, addr uint64) *elf.Prog {
for _, p := range elfFile.Progs {
Expand Down
1 change: 0 additions & 1 deletion pkg/proc/eval.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1039,7 +1039,6 @@ func (stack *evalStack) executeOp() {
} else {
stack.err = fmt.Errorf("could not find symbol value for %s", op.Name)
}

}

case *evalop.PushIdent:
Expand Down
3 changes: 0 additions & 3 deletions pkg/proc/proc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6305,7 +6305,6 @@ func TestRangeOverFuncNext(t *testing.T) {
f, ln2 = currentLineNumber(p, t)
if ln2 != n {
t.Fatalf("Program did not continue to correct next location (expected %d) was %s:%d", n, f, ln2)

}
}}
}
Expand Down Expand Up @@ -6365,7 +6364,6 @@ func TestRangeOverFuncNext(t *testing.T) {
}

withTestProcessArgs("rangeoverfunc", t, ".", []string{}, 0, func(p *proc.Target, grp *proc.TargetGroup, fixture protest.Fixture) {

t.Run("TestTrickyIterAll1", func(t *testing.T) {
testseq2intl(t, fixture, grp, p, nil, []seqTest{
funcBreak(t, "main.TestTrickyIterAll"),
Expand Down Expand Up @@ -6889,7 +6887,6 @@ func TestRangeOverFuncNextInlined(t *testing.T) {
}

withTestProcessArgs("rangeoverfunc", t, ".", []string{}, protest.EnableInlining, func(p *proc.Target, grp *proc.TargetGroup, fixture protest.Fixture) {

t.Run("TestTrickyIterAll1", func(t *testing.T) {
testseq2intl(t, fixture, grp, p, nil, []seqTest{
funcBreak(t, "main.TestTrickyIterAll"),
Expand Down
3 changes: 0 additions & 3 deletions service/debugger/debugger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,6 @@ func (d *Debugger) Restart(rerecord bool, pos string, resetArgs bool, newArgs []

if !resetArgs && (d.config.Stdout.File != nil || d.config.Stderr.File != nil) {
return nil, ErrCanNotRestart

}

if err := d.detach(true); err != nil {
Expand Down Expand Up @@ -1547,7 +1546,6 @@ func traverse(t proc.ValidTargets, f *proc.Function, depth int, followCalls int)
TraceMap[cf.Name] = childnode
queue = append(queue, childnode)
}

}
}
}
Expand Down Expand Up @@ -2001,7 +1999,6 @@ func (d *Debugger) convertDefers(defers []*proc.Defer) []api.Defer {
SP: defers[i].SP,
}
}

}

return r
Expand Down