pkg/proc: fix watchpoints on macos #3703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems newer MacOS kernels are sending mach exceptions for watchpoints which contain the hardware register number as opposed to the address which triggered the exception. Also, ARM64 seems to have switched to sending _EXC_I386_SGL as medata[0] for this exception type.
derekparker
commented
Apr 14, 2024
|
Marking as draft as I'm still iterating on this. |
This should be more reliable than checking for function name.
aarzilli
reviewed
Apr 21, 2024
pkg/proc/proc_test.go
Outdated
| @@ -5501,7 +5511,7 @@ func TestWatchpointCounts(t *testing.T) { | |||
| } | |||
|
|
|||
| t.Logf("TotalHitCount: %d", bp.Logical.TotalHitCount) | |||
| if bp.Logical.TotalHitCount != 200 { | |||
| if bp.Logical.TotalHitCount < 200 { | |||
There was a problem hiding this comment.
This check should be exact, if it is more than 200 it means we are counting some hits multiple times, which is a bug.
There was a problem hiding this comment.
Never mind, now it's broken in CI. I'll take a look into this.
There was a problem hiding this comment.
Never mind, now it's broken in CI. I'll take a look into this.
I've sent in a patch to skip the two watchpoint tests failing in CI. The macOS version (and subsequently the kernel) are ~4 years old and officially unsupported by Apple, so the likelihood anyone is actually running this version in the wild, especially a developer, is extremely low.
The tests pass reliably on my machine ™️ and this patch fixes watchpoints on my machine, which previously were completely broken. I've already reached out to the JetBrains folks to update our macOS builders to a more recent, supported version.
yurishkuro
pushed a commit
to jaegertracing/jaeger
that referenced
this pull request
Aug 17, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-delve/delve](https://togithub.com/go-delve/delve) | `v1.22.1` -> `v1.23.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>go-delve/delve (github.com/go-delve/delve)</summary> ### [`v1.23.0`](https://togithub.com/go-delve/delve/releases/tag/v1.23.0) [Compare Source](https://togithub.com/go-delve/delve/compare/v1.22.1...v1.23.0) #### What's Changed - dwarfbuilder: fix makeAbbrevTable by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3665 - \*: misc fixes for go1.23 by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3663 - elfwriter: add WriteSectionHeaders by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3666 - Upgrade github.com/google/go-dap to v0.12.0 by [@​suzmue](https://togithub.com/suzmue) in [go-delve/delve#3673 - pkg/terminal,pkg/proc: Implement next-instruction by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3671 - pkg/terminal: print breakpoint number on stop by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3675 - proc/evalop: remove no longer needed Go 1.17 files by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3676 - Cirrus-CI: update to FreeBSD 13.3 by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3679 - dwarf/loclist: remove impossible condition by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3677 - proc: catch panics when reading debug info for stripped executables by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3678 - proc,go.mod: update x/sys remove KeepAlive calls by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3680 - pkg/proc: defend better against missing DWARF by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3695 - proc: support reading captured variables of closures by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3682 - pkg/terminal: allow postfix if for breakpoint conds by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3693 - proc: change 'step' command so that it steps through go statements by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3686 - cmd/dlv: add shell (non-)completions to flags taking args by [@​scop](https://togithub.com/scop) in [go-delve/delve#3696 - cmd/dlv: fix panic on connect fail by [@​scop](https://togithub.com/scop) in [go-delve/delve#3698 - tests: fix tests on Go 1.23 by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3697 - pkg/terminal: clear erroneous name setting on postfix if by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3702 - pkg/terminal: remove duplicated word by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3707 - cmd/dlv: improve positional argument completion by [@​scop](https://togithub.com/scop) in [go-delve/delve#3699 - proc: generalize escapeCheck and allocString by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3687 - rr: fix gdb parsing by [@​howardjohn](https://togithub.com/howardjohn) in [go-delve/delve#3705 - Add function name even in return trace by [@​archanaravindar](https://togithub.com/archanaravindar) in [go-delve/delve#3712 - pkg/proc: fix watchpoints on macos by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3703 - \_scripts: upgrade to python3 by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3716 - pkg/proc/gdbserial: optimize gdbwire backend by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3715 - gdbserial: update path of lldb protocol extension documentation by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3727 - gdbserial: fixes for rr 5.7.0 by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3718 - pkg/terminal: remove deprecated starlark global options by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3722 - \*: remove redundant lines at the start/end of block by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3730 - Update actions/checkout to v4 by [@​abbasudo](https://togithub.com/abbasudo) in [go-delve/delve#3731 - proc/gdbserial: add environment variables to configure rr invocation by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3726 - proc: initial stepping with range-over-func support by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3736 - cmd/dlv: print out message with stack trace when breakpoint is hit but has no waiting client by [@​fatanugraha](https://togithub.com/fatanugraha) in [go-delve/delve#3632 - Support to add a new suboption --follow-calls to trace subcommand by [@​archanaravindar](https://togithub.com/archanaravindar) in [go-delve/delve#3594 - proc: fix bug with stack watchpoints going out of scope by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3742 - proc: fix TestRangeOverFuncNext by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3740 - proc: refactor identifier evaluation for range-over-func support by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3738 - service: print better message for unattended stops by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3747 - pkg/astutil,pkg/elfwriter: fix package doc by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3753 - \*: replace fmt.Errorf with errors.New by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3752 - proc: initial support for expressions with range-over-func by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3750 - pkg/terminal: do not use deprecated strings.Title by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3756 - all: fix typos in CHANGELOG, comments and package name by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3757 - refactor: move loadModuleData from runtimeTypeToDIE and expose the apis by [@​jayantxie](https://togithub.com/jayantxie) in [go-delve/delve#3741 - pkg/proc,service/debugger: fix debuginfod-find source by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3762 - fix: mem cache out of range panic caused by overflow by [@​jayantxie](https://togithub.com/jayantxie) in [go-delve/delve#3761 - proc: support stepping through range-over-func statements with inlining by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3755 - service/debugger: evaluate breakpoint vars on g-less threads by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3759 - fix: LoadAbstractOriginAndSpecification infinite loop caused by abstr… by [@​zdyj3170101136](https://togithub.com/zdyj3170101136) in [go-delve/delve#3767 - \*: remove redundant lines at the start/end of block by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3773 - pkg/proc: fix 404 links and change to https by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3775 - go.mod: update gopkg.in/yaml to v3 by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3776 - pkg/terminal: add missing file.Close() call by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3770 - pkg: refactor to .WriteString() instead of .Write(\[]byte()) by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3769 - pkg/dwarf/line: use t.Logf instead of fmt.Printf in tests by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3772 - proc: use .closureptr for stepping through range-over-func statements by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3763 - service/rpc1: add Go Reference doc by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3779 - \*: replace old golang.org links with new go.dev by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3774 - proc: fix bug with range-over-func stepping by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3778 - goversion: add 1.23 to supported versions, update test matrix by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3780 - teamcity: fix typo in configuration by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3783 - \*: release version 1.23.0 by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3782 #### New Contributors - [@​scop](https://togithub.com/scop) made their first contribution in [go-delve/delve#3696 - [@​howardjohn](https://togithub.com/howardjohn) made their first contribution in [go-delve/delve#3705 - [@​abbasudo](https://togithub.com/abbasudo) made their first contribution in [go-delve/delve#3731 - [@​fatanugraha](https://togithub.com/fatanugraha) made their first contribution in [go-delve/delve#3632 - [@​jayantxie](https://togithub.com/jayantxie) made their first contribution in [go-delve/delve#3741 - [@​zdyj3170101136](https://togithub.com/zdyj3170101136) made their first contribution in [go-delve/delve#3767 **Full Changelog**: https://github.com/go-delve/delve/blob/master/CHANGELOG.md#1230-2024-07-16 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/jaegertracing/jaeger). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiY2hhbmdlbG9nOmRlcGVuZGVuY2llcyJdfQ==--> Signed-off-by: Mend Renovate <bot@renovateapp.com>
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 28, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-delve/delve](https://togithub.com/go-delve/delve) | `v1.22.1` -> `v1.23.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>go-delve/delve (github.com/go-delve/delve)</summary> ### [`v1.23.0`](https://togithub.com/go-delve/delve/releases/tag/v1.23.0) [Compare Source](https://togithub.com/go-delve/delve/compare/v1.22.1...v1.23.0) #### What's Changed - dwarfbuilder: fix makeAbbrevTable by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3665 - \*: misc fixes for go1.23 by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3663 - elfwriter: add WriteSectionHeaders by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3666 - Upgrade github.com/google/go-dap to v0.12.0 by [@​suzmue](https://togithub.com/suzmue) in [go-delve/delve#3673 - pkg/terminal,pkg/proc: Implement next-instruction by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3671 - pkg/terminal: print breakpoint number on stop by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3675 - proc/evalop: remove no longer needed Go 1.17 files by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3676 - Cirrus-CI: update to FreeBSD 13.3 by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3679 - dwarf/loclist: remove impossible condition by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3677 - proc: catch panics when reading debug info for stripped executables by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3678 - proc,go.mod: update x/sys remove KeepAlive calls by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3680 - pkg/proc: defend better against missing DWARF by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3695 - proc: support reading captured variables of closures by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3682 - pkg/terminal: allow postfix if for breakpoint conds by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3693 - proc: change 'step' command so that it steps through go statements by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3686 - cmd/dlv: add shell (non-)completions to flags taking args by [@​scop](https://togithub.com/scop) in [go-delve/delve#3696 - cmd/dlv: fix panic on connect fail by [@​scop](https://togithub.com/scop) in [go-delve/delve#3698 - tests: fix tests on Go 1.23 by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3697 - pkg/terminal: clear erroneous name setting on postfix if by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3702 - pkg/terminal: remove duplicated word by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3707 - cmd/dlv: improve positional argument completion by [@​scop](https://togithub.com/scop) in [go-delve/delve#3699 - proc: generalize escapeCheck and allocString by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3687 - rr: fix gdb parsing by [@​howardjohn](https://togithub.com/howardjohn) in [go-delve/delve#3705 - Add function name even in return trace by [@​archanaravindar](https://togithub.com/archanaravindar) in [go-delve/delve#3712 - pkg/proc: fix watchpoints on macos by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3703 - \_scripts: upgrade to python3 by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3716 - pkg/proc/gdbserial: optimize gdbwire backend by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3715 - gdbserial: update path of lldb protocol extension documentation by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3727 - gdbserial: fixes for rr 5.7.0 by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3718 - pkg/terminal: remove deprecated starlark global options by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3722 - \*: remove redundant lines at the start/end of block by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3730 - Update actions/checkout to v4 by [@​abbasudo](https://togithub.com/abbasudo) in [go-delve/delve#3731 - proc/gdbserial: add environment variables to configure rr invocation by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3726 - proc: initial stepping with range-over-func support by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3736 - cmd/dlv: print out message with stack trace when breakpoint is hit but has no waiting client by [@​fatanugraha](https://togithub.com/fatanugraha) in [go-delve/delve#3632 - Support to add a new suboption --follow-calls to trace subcommand by [@​archanaravindar](https://togithub.com/archanaravindar) in [go-delve/delve#3594 - proc: fix bug with stack watchpoints going out of scope by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3742 - proc: fix TestRangeOverFuncNext by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3740 - proc: refactor identifier evaluation for range-over-func support by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3738 - service: print better message for unattended stops by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3747 - pkg/astutil,pkg/elfwriter: fix package doc by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3753 - \*: replace fmt.Errorf with errors.New by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3752 - proc: initial support for expressions with range-over-func by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3750 - pkg/terminal: do not use deprecated strings.Title by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3756 - all: fix typos in CHANGELOG, comments and package name by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3757 - refactor: move loadModuleData from runtimeTypeToDIE and expose the apis by [@​jayantxie](https://togithub.com/jayantxie) in [go-delve/delve#3741 - pkg/proc,service/debugger: fix debuginfod-find source by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3762 - fix: mem cache out of range panic caused by overflow by [@​jayantxie](https://togithub.com/jayantxie) in [go-delve/delve#3761 - proc: support stepping through range-over-func statements with inlining by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3755 - service/debugger: evaluate breakpoint vars on g-less threads by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3759 - fix: LoadAbstractOriginAndSpecification infinite loop caused by abstr… by [@​zdyj3170101136](https://togithub.com/zdyj3170101136) in [go-delve/delve#3767 - \*: remove redundant lines at the start/end of block by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3773 - pkg/proc: fix 404 links and change to https by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3775 - go.mod: update gopkg.in/yaml to v3 by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3776 - pkg/terminal: add missing file.Close() call by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3770 - pkg: refactor to .WriteString() instead of .Write(\[]byte()) by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3769 - pkg/dwarf/line: use t.Logf instead of fmt.Printf in tests by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3772 - proc: use .closureptr for stepping through range-over-func statements by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3763 - service/rpc1: add Go Reference doc by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3779 - \*: replace old golang.org links with new go.dev by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3774 - proc: fix bug with range-over-func stepping by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3778 - goversion: add 1.23 to supported versions, update test matrix by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3780 - teamcity: fix typo in configuration by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3783 - \*: release version 1.23.0 by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3782 #### New Contributors - [@​scop](https://togithub.com/scop) made their first contribution in [go-delve/delve#3696 - [@​howardjohn](https://togithub.com/howardjohn) made their first contribution in [go-delve/delve#3705 - [@​abbasudo](https://togithub.com/abbasudo) made their first contribution in [go-delve/delve#3731 - [@​fatanugraha](https://togithub.com/fatanugraha) made their first contribution in [go-delve/delve#3632 - [@​jayantxie](https://togithub.com/jayantxie) made their first contribution in [go-delve/delve#3741 - [@​zdyj3170101136](https://togithub.com/zdyj3170101136) made their first contribution in [go-delve/delve#3767 **Full Changelog**: https://github.com/go-delve/delve/blob/master/CHANGELOG.md#1230-2024-07-16 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/jaegertracing/jaeger). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiY2hhbmdlbG9nOmRlcGVuZGVuY2llcyJdfQ==--> Signed-off-by: Mend Renovate <bot@renovateapp.com> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems newer MacOS kernels are sending mach exceptions for watchpoints which contain the hardware register number as opposed to the address which triggered the exception. Also, ARM64 seems to have switched to sending _EXC_I386_SGL as medata[0] for this exception type.