proc: if a reslice operator is used load the whole slice #3623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the users uses a reslice operation load the whole resliced variable, ignoring the MaxArrayValues setting. Only apply this when the 'high' part is specified and a literal and the 'low' part is either unspecified or a literal. Fixes go-delve#3600
derekparker
reviewed
Jan 10, 2024
| } | ||
|
|
||
| if node.Low != nil { | ||
| err = ctx.compileAST(node.Low) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| _, isbasiclit := node.Low.(*ast.BasicLit) |
There was a problem hiding this comment.
Why perform this check on the low side, what would cause us to not trust the length depending on the low side of the slice operation?
There was a problem hiding this comment.
My thinking is that we only do this when the expression has a fixed length and something like s[a:1000000] doesn't.
|
Yay, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the users uses a reslice operation load the whole resliced
variable, ignoring the MaxArrayValues setting.
Only apply this when the 'high' part is specified and a literal and the
'low' part is either unspecified or a literal.
Fixes #3600