service: fix a bunch of linter warnings from GoLand #3551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarzilli
reviewed
Nov 3, 2023
| defer s.conn.Close() | ||
| defer func() { |
There was a problem hiding this comment.
I don't think this refactoring is actually a refactoring. The original code only does this after checking s.config.StopTriggered.
There was a problem hiding this comment.
You're right, we should add a sentinel value to determine if we should call this, good catch. I just wanted to avoid a defer call within the loop, especially because that loop has a continue which could cause a leak.
| @@ -606,10 +613,10 @@ func (s *Session) handleRequest(request dap.Message) { | |||
| case *dap.PauseRequest: // Required | |||
| s.onPauseRequest(request) | |||
| return | |||
| case *dap.TerminateRequest: // Optional (capability ‘supportsTerminateRequest‘) | |||
There was a problem hiding this comment.
I guess GoLand doesn't like unicode in comments? I'm ok with this, I just think it's a weird thing to complain about for a linter.
There was a problem hiding this comment.
This was me actually, I think it's just cleaner to have uniform quotes.
| @@ -379,7 +379,7 @@ func (s *Server) Stop() { | |||
|
|
|||
| if s.listener != nil { | |||
| // If run goroutine is blocked on accept, this will unblock it. | |||
| _ = s.listener.Close() | |||
There was a problem hiding this comment.
This is actually removing the _ = not adding it.
service/debugger/debugger.go
Outdated
| @@ -546,7 +546,7 @@ func (d *Debugger) Restart(rerecord bool, pos string, resetArgs bool, newArgs [] | |||
| return nil, fmt.Errorf("could not launch process: %s", err) | |||
| } | |||
|
|
|||
| discarded := []api.DiscardedBreakpoint{} | |||
There was a problem hiding this comment.
I don't like this level of style enforcement. This seems too arbitrary to me.
There was a problem hiding this comment.
That's fine, we don't have to enforce it going forward to new PRs or anything, it's just a bit of cleanup. Changes things somewhat semantically, but nothing that has any real effect here.
aarzilli
approved these changes
Nov 5, 2023
kakkoyun
added a commit
to parca-dev/parca-agent
that referenced
this pull request
Jan 8, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-delve/delve](https://togithub.com/go-delve/delve) | `v1.21.2` -> `v1.22.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>go-delve/delve (github.com/go-delve/delve)</summary> ### [`v1.22.0`](https://togithub.com/go-delve/delve/releases/tag/v1.22.0) [Compare Source](https://togithub.com/go-delve/delve/compare/v1.21.2...v1.22.0) #### What's Changed - all: remove obsolete build tags by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3513 - service/dap: add the concrete type to interface type by [@​suzmue](https://togithub.com/suzmue) in [go-delve/delve#3510 - service/dap: fix bugs in stdout/stderr handling by [@​hyangah](https://togithub.com/hyangah) in [go-delve/delve#3522 - pkg/terminal: support vscode in edit command by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3524 - Use a valid timezone in tested binary by [@​upils](https://togithub.com/upils) in [go-delve/delve#3527 - proc: implement follow exec mode on Windows by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3507 - service/test: disable TestClientServer_chanGoroutines with rr backend by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3492 - proc/native: use cgo instead of C for freebsd by [@​4a6f656c](https://togithub.com/4a6f656c) in [go-delve/delve#3529 - proc: use DW_AT_trampoline to detect auto-generated code by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3528 - proc: use stack machine to evaluate expressions by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3508 - proc: fix comment typos by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3531 - proc: add min and max builtins by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3530 - CI: update staticcheck version by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3533 - proc: remove expr evaluation goroutine from EvalExpressionWithCalls by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3532 - service/api: use bitfield for prettyprint flags by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3536 - proc: allow evaluator to reference previous frames by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3534 - \*: Add explicit code of conduct by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3540 - proc,service/dap,proc/gdbserial: fixes for debugserver --unmask-signals by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3541 - \*: release 1.21.2 (for master) by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3546 - proc/native: wherever we check for exited we should also check detached by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3547 - pkg/proc: add inline function support for stripped binaries by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3549 - cmd: fix a bunch of linter warnings from GoLand by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3550 - proc: add regression test for issue [#​3548](https://togithub.com/go-delve/delve/issues/3548) by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3553 - \*: update dependencies by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3552 - service: fix a bunch of linter warnings from GoLand by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3551 - \*: Correct spelling mistakes by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3555 - pkg,service: Remove redundant build constraints by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3556 - Shorten variable types by [@​stefanhaller](https://togithub.com/stefanhaller) in [go-delve/delve#3535 - TeamCity: reupgrade linux/386 builder to Go 1.21 by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3560 - pkg/proc: improve support unwinding from sigpanic by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3559 - pkg/proc: unskip passing tests and reorganize by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3561 - chore: use strings.Contains instead by [@​testwill](https://togithub.com/testwill) in [go-delve/delve#3562 - pkg,service: remove unnecessary convertions by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3564 - \*: remove checks for TRAVIS env variable by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3568 - terminal: clear substitute path rules cache when config is used by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3567 - service: fix typo in variable name by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3575 - TeamCity: remove windows/arm64 builders from chain by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3572 - proc: simplify and generalize runtime.mallocgc workaround by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3571 - proc/gdbserial: refactor parsing of key-value pairs from gdb protocol by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3574 - Extract tip builds into a separate sub-project by [@​artspb](https://togithub.com/artspb) in [go-delve/delve#3578 - pkg,service/dap: use switch instead of if-else-if by [@​alexandear](https://togithub.com/alexandear) in [go-delve/delve#3576 - CI: update teamcity settings by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3579 - pkg/proc: use gore to obtain info from stripped binaries by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3577 - add missing import in TeamCity DSL by [@​artspb](https://togithub.com/artspb) in [go-delve/delve#3580 - update TeamCity DSL version to 2023.05 and remove tip configurations from Aggregator by [@​artspb](https://togithub.com/artspb) in [go-delve/delve#3581 - proc: fix TestIssue1101 flake by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3585 - proc: skip trapthread for harcoded breakpoints after manual stop by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3582 - tests: fix tests in go1.22 by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3583 - all: run go mod tidy by [@​prattmic](https://togithub.com/prattmic) in [go-delve/delve#3589 - add all branches but PRs to filter by [@​artspb](https://togithub.com/artspb) in [go-delve/delve#3590 - service/dap: fix close on closed channel panic by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3573 - Show pprof labels in thread names by [@​stefanhaller](https://togithub.com/stefanhaller) in [go-delve/delve#3501 - \*: Use forked goretk/gore module by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3597 - proc: make some type casts less counterintuitive by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3596 - teamcity,version: add 1.22 to supported versions and CI matrix by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3601 - proc: fix ppc64 arch name check by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3608 - goversion: include pre-releases in VersionAfterOrEqual check by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3607 - service/dap: fix close on closed channel by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3609 - proc: fix TestPackageRenames on go1.22 on linux/386 by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3610 - \*: Update gore dep for 1.22 by [@​derekparker](https://togithub.com/derekparker) in [go-delve/delve#3611 - \*: release version 1.22.0 by [@​aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3606 #### New Contributors - [@​upils](https://togithub.com/upils) made their first contribution in [go-delve/delve#3527 - [@​testwill](https://togithub.com/testwill) made their first contribution in [go-delve/delve#3562 - [@​prattmic](https://togithub.com/prattmic) made their first contribution in [go-delve/delve#3589 **Full Changelog**: go-delve/delve@v1.21.1...v1.22.0 **Curated Changelog**: https://github.com/go-delve/delve/blob/master/CHANGELOG.md#1220-2023-12-29 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/parca-dev/parca-agent). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.