Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proc: disable "wait-for" tests on freebsd #3482

Merged
merged 1 commit into from
Aug 23, 2023
Merged

proc: disable "wait-for" tests on freebsd #3482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Documentation/backend_test_health.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ Tests skipped by each supported backend:
* 2 broken - cgo stacktraces
* darwin/lldb skipped = 1
* 1 upstream issue
* freebsd skipped = 4
* freebsd skipped = 6
* 2 flaky
* 4 not implemented
* linux/386/pie skipped = 1
* 1 broken
Expand Down
2 changes: 2 additions & 0 deletions pkg/proc/proc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6197,6 +6197,7 @@ func testWaitForSetup(t *testing.T, mu *sync.Mutex, started *bool) (*exec.Cmd, *

func TestWaitFor(t *testing.T) {
skipOn(t, "waitfor implementation is delegated to debugserver", "darwin")
skipOn(t, "flaky", "freebsd")

var mu sync.Mutex
started := false
Expand All @@ -6214,6 +6215,7 @@ func TestWaitFor(t *testing.T) {
}

func TestWaitForAttach(t *testing.T) {
skipOn(t, "flaky", "freebsd")
if testBackend == "lldb" && runtime.GOOS == "linux" {
bs, _ := ioutil.ReadFile("/proc/sys/kernel/yama/ptrace_scope")
if bs == nil || strings.TrimSpace(string(bs)) != "0" {
Expand Down