test(gnoclient): Fix a potential bug in the integration test #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2558 +/- ##
==========================================
- Coverage 54.96% 54.88% -0.08%
==========================================
Files 595 595
Lines 79568 79356 -212
==========================================
- Hits 43734 43557 -177
+ Misses 32527 32506 -21
+ Partials 3307 3293 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
moul
approved these changes
Jul 9, 2024
thehowl
reviewed
Jul 9, 2024
thehowl
approved these changes
Jul 9, 2024
thehowl
changed the title
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
…#2558)  I'm not sure about the root cause, but it seems like the test node isn't ready to handle the request call, so it returns an error. Using the result immediately without asserting that there's no error will cause this section to panic, leading to a CI that fails randomly You can see https://github.com/gnolang/gno/actions/runs/9855164413/job/27209502761?pr=2518 <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Morgan <git@howl.moe>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure about the root cause, but it seems like the test node isn't ready to handle the request call, so it returns an error. Using the result immediately without asserting that there's no error will cause this section to panic, leading to a CI that fails randomly
You can see https://github.com/gnolang/gno/actions/runs/9855164413/job/27209502761?pr=2518
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description