Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bad module naming in gov package #2339

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: bad module naming in gov package #2339

merged 1 commit into from
Jun 12, 2024

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Jun 12, 2024 •
edited
Loading

This PR addresses the issue of poor module naming introduced in the recent merge #1945.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@gfanton
fix: bad module name
27cbc1b 
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
@gfanton gfanton requested review from moul and a team as code owners June 12, 2024 13:55
@gfanton gfanton requested review from piux2 and removed request for a team June 12, 2024 13:55
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jun 12, 2024
@zivkovicmilos zivkovicmilos added the hotfix Major bug fix that should be merged ASAP label Jun 12, 2024
@zivkovicmilos
Copy link
Member

Confirming hotfix works 👍

@zivkovicmilos
Copy link
Member

Thank you @n0izn0iz for the ping 🙏

@zivkovicmilos zivkovicmilos merged commit 719ee92 into gnolang:master Jun 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@moul moul Awaiting requested review from moul moul is a code owner

@piux2 piux2 Awaiting requested review from piux2 piux2 is a code owner automatically assigned from gnolang/tech-staff

Assignees

@gfanton gfanton

Labels
hotfix Major bug fix that should be merged ASAP 🧾 package/realm Tag used for new Realms or Packages.
Projects
💪 Bounties & Worx
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfanton @zivkovicmilos