Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnoweb): update "airgapped" commands in realm help page #2244

Merged
merged 5 commits into from
Jun 6, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented May 30, 2024

This matches gnokey sign's behaviour to the updated version from #1976. I've manually tested this on a local node, and it works.

@thehowl thehowl self-assigned this May 30, 2024
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.95%. Comparing base (4dafb8a) to head (9cbdf5f).

Files Patch % Lines
gno.land/pkg/keyscli/addpkg.go 0.00% 1 Missing ⚠️
gno.land/pkg/keyscli/run.go 0.00% 1 Missing ⚠️
tm2/pkg/crypto/keys/client/broadcast.go 0.00% 1 Missing ⚠️
tm2/pkg/crypto/keys/client/send.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2244      +/-   ##
==========================================
- Coverage   54.60%   49.95%   -4.66%     
==========================================
  Files         579      578       -1     
  Lines       77896    77794     -102     
==========================================
- Hits        42539    38861    -3678     
- Misses      32185    35809    +3624     
+ Partials     3172     3124      -48     
Flag Coverage Δ
gno.land 61.67% <33.33%> (+0.04%) ⬆️
tm2 54.44% <33.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moul
Copy link
Member

moul commented May 30, 2024

Can you add a txtar file named gnoweb-airgapped.txtar so we have a regression test that will automatically fail if we break CLI compatibility again?

In addition, this will allow me to reuse the txtar logic that uses stdout.

@moul
Copy link
Member

moul commented May 30, 2024

Btw, I think that #1976 removes the possibility to sign the same tx twice, with two different accounts from CLI.

@thehowl thehowl requested review from jaekwon, gfanton and a team as code owners May 30, 2024 18:18
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label May 30, 2024
@thehowl
Copy link
Member Author

thehowl commented May 30, 2024

@moul done; some fine tuning to get there as not all commands in gnokey were actually using io as intended.

@thehowl
Copy link
Member Author

thehowl commented May 30, 2024

Btw, I think that #1976 removes the possibility to sign the same tx twice, with two different accounts from CLI.

yes, I have some doubts about what the PR did as well. I've asked milos to clarify, but we may end up changing some behaviour again.

@thehowl thehowl requested a review from alexiscolin June 3, 2024 18:16
@thehowl thehowl merged commit 74c2b31 into master Jun 6, 2024
39 of 42 checks passed
@thehowl thehowl deleted the dev/morgan/fix-website-cli-instructions branch June 6, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants