Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stdlibs/time): add DateTime, DateOnly and TimeOnly #2240

Merged
merged 2 commits into from
May 30, 2024

Conversation

deelawn
Copy link
Contributor

@deelawn deelawn commented May 30, 2024

This just adds a few missing time format constants to the time gno module.

@deelawn deelawn requested a review from thehowl as a code owner May 30, 2024 02:45
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.95%. Comparing base (98bd124) to head (d74ff30).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2240   +/-   ##
=======================================
  Coverage   49.94%   49.95%           
=======================================
  Files         577      577           
  Lines       77858    77858           
=======================================
+ Hits        38889    38893    +4     
+ Misses      35843    35838    -5     
- Partials     3126     3127    +1     
Flag Coverage Δ
gnovm 45.08% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deelawn deelawn requested review from a team as code owners May 30, 2024 03:14
@deelawn deelawn requested review from zivkovicmilos and removed request for a team May 30, 2024 03:14
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label May 30, 2024
@thehowl thehowl changed the title chore: added missing time formats feat(stdlibs/time): add DateTime, DateOnly and TimeOnly May 30, 2024
@thehowl thehowl merged commit 0ee8bdc into gnolang:master May 30, 2024
47 checks passed
omarsy pushed a commit to TERITORI/gno that referenced this pull request Jun 3, 2024
This just adds a few missing time format constants to the time gno
module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants