Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): forbid usage of regexp.Match(String)? #2066

Merged
merged 4 commits into from
May 26, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented May 9, 2024

Just to avoid this comment again :)

@thehowl thehowl self-assigned this May 9, 2024
@thehowl thehowl requested review from moul, a team, jaekwon, piux2 and zivkovicmilos as code owners May 9, 2024 14:58
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.07%. Comparing base (0a1e732) to head (5e2712b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2066      +/-   ##
==========================================
- Coverage   49.09%   49.07%   -0.02%     
==========================================
  Files         576      576              
  Lines       77842    77821      -21     
==========================================
- Hits        38216    38192      -24     
- Misses      36532    36533       +1     
- Partials     3094     3096       +2     
Flag Coverage Δ
contribs/gnodev 24.18% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
misc/autocounterd 0.00% <ø> (ø)
misc/genproto 0.00% <ø> (ø)
misc/genstd 73.90% <ø> (ø)
misc/goscan 0.00% <ø> (ø)
misc/logos 17.68% <ø> (+0.30%) ⬆️
misc/loop 0.00% <ø> (ø)
tm2 54.45% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl merged commit 50bf659 into master May 26, 2024
79 checks passed
@thehowl thehowl deleted the dev/morgan/linter-regexp-match branch May 26, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants