Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnovm): revert "top sort var/const globals (#1854)" #1956

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Apr 19, 2024

per discussion with @jaekwon; see #1854 (comment)

@thehowl thehowl self-assigned this Apr 19, 2024
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.78%. Comparing base (5a976ef) to head (1ff2ef3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1956      +/-   ##
==========================================
+ Coverage   45.18%   47.78%   +2.59%     
==========================================
  Files         465      393      -72     
  Lines       68081    61602    -6479     
==========================================
- Hits        30763    29437    -1326     
+ Misses      34742    29695    -5047     
+ Partials     2576     2470     -106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl
Copy link
Member Author

thehowl commented Apr 24, 2024

jae asked me to undo the merge in DMs, so merging.

@thehowl thehowl merged commit 2af6365 into master Apr 24, 2024
196 of 197 checks passed
@thehowl thehowl deleted the dev/morgan/revert-1854 branch April 24, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants