chore: archive old demo #1940
Merged
chore: archive old demo #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moul <94029+moul@users.noreply.github.com>
github-actions
bot
added
the
🧾 package/realm
|
hm. why? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1940 +/- ##
==========================================
- Coverage 47.77% 45.09% -2.69%
==========================================
Files 393 464 +71
Lines 61630 68039 +6409
==========================================
+ Hits 29443 30679 +1236
- Misses 29717 34784 +5067
- Partials 2470 2576 +106 ☔ View full report in Codecov by Sentry. |
|
First, refer to this to understand its level of deprecation: https://github.com/moul/gno/blob/dev/moul/archive-old-code/examples/gno.land/p/archives/bank/types.gno#L129-L139 Second, it's not used by anything. It's helpful to maintain as an archive for running tests and linters. It's not a demo for others to follow; rather, it's very old, unfinished, dead code. It makes sense to update the logic code for current use and create a real demo. |
gfanton
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: moul 94029+moul@users.noreply.github.com
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description