feat(stdlibs/std): restrict Banker methods based on caller of GetBanker #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1921 +/- ##
=======================================
Coverage 54.70% 54.71%
=======================================
Files 583 583
Lines 78504 78492 -12
=======================================
Hits 42946 42946
+ Misses 32349 32337 -12
Partials 3209 3209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zivkovicmilos
approved these changes
May 15, 2024
|
@r3v4s Can you please rebase with the latest |
thehowl
reviewed
May 29, 2024
thehowl
reviewed
May 29, 2024
thehowl
reviewed
May 29, 2024
r3v4s
force-pushed
the
fix/banker-permission-2
branch
from
3e07fc5
to
00c7e30
Compare
thehowl
reviewed
Jun 28, 2024
Co-authored-by: Morgan <git@howl.moe>
thehowl
approved these changes
Jul 2, 2024
thehowl
changed the title
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
…er (gnolang#1921) related pr gnolang#1787 There was bit of extra conversion in previous pr after merged. 1) revert test cases 2) allow `Send` from realm that created banker rather the one calling <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Morgan <git@howl.moe>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related pr #1787
There was bit of extra conversion in previous pr after merged.
Sendfrom realm that created banker rather the one callingContributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description