feat: PrevRealm ignores user realms in MsgRun #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix gnolang#1664 As commented in the IsRealm() method, a better format of user realms should emerge in the form of `gno.land/u/user_address`, which would remove the confusion between standard realms and the realm forged under the MsgRun transaction.
github-actions
bot
added
📦 🤖 gnovm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1719 +/- ##
=======================================
Coverage 49.01% 49.01%
=======================================
Files 576 576
Lines 77604 77605 +1
=======================================
+ Hits 38035 38036 +1
- Misses 36486 36487 +1
+ Partials 3083 3082 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thehowl
reviewed
Mar 4, 2024
leohhhn
changed the title
|
@tbruyelle If I understand correctly, this only modifies the PrevRealm in case of MsgRun? If so, I changed the name of the PR to make it more clear |
Yes, this is exactly that, thanks for the clarification. |
zivkovicmilos
added
the
breaking change
zivkovicmilos
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1664
As commented in the IsRealm() method, a better format of user realms should emerge in the form of
gno.land/u/user_address, which would remove the confusion between standard realms and the realm forged under the MsgRun transaction.BREAKING CHANGE:
std.PrevRealmis not returning the user realm any more when invoked under a transaction broadcasted byMsgRun.To run the txtar test:
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description