feat(cmd/gno)!: change all -verbose flags to -v
#1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1716 +/- ##
==========================================
- Coverage 47.41% 47.41% -0.01%
==========================================
Files 384 384
Lines 61240 61230 -10
==========================================
- Hits 29040 29030 -10
Misses 29771 29771
Partials 2429 2429 ☔ View full report in Codecov by Sentry. |
harry-hov
approved these changes
Mar 4, 2024
|
what do you think about removing |
thehowl
changed the title
-verbose flags to -v
thehowl
changed the title
-verbose flags to -v-verbose flags to -v
|
@harry-hov bold, I like it :) done |
leohhhn
approved these changes
Mar 4, 2024
|
After posting this on signal, there seems to be an overwhelming consensus to do this, so going ahead and merging :) |
leohhhn
pushed a commit
to leohhhn/gno
that referenced
this pull request
Mar 6, 2024
BREAKING CHANGE: `-verbose` is no longer a flag recognised by any command. All its usages should be switched to `-v`. Per the decision on gnolang#1555, we now have some exceptions for common scenarios where short flags make sense. `gno test -v` is super-useful as it connects to the muscle memory a Go developer has (with `go test -v`), so this PR adds it.
leohhhn
pushed a commit
to leohhhn/gno
that referenced
this pull request
Mar 6, 2024
Leftover from PR gnolang#1716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the decision on #1555, we now have some exceptions for common scenarios where short flags make sense.
gno test -vis super-useful as it connects to the muscle memory a Go developer has (withgo test -v), so this PR adds it.