refactor always-firing

gmmorris · Nov 12, 2020 · 2f576ab · 2f576ab
1 parent 036889f
commit 2f576ab
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/x-pack/examples/alerting_example/public/alert_types/always_firing.tsx b/x-pack/examples/alerting_example/public/alert_types/always_firing.tsx
@@ -73,6 +73,15 @@ export const AlwaysFiringExpression: React.FunctionComponent<AlertTypeParamsExpr
     thresholds = pick(DEFAULT_THRESHOLDS, defaultActionGroupId),
   } = alertParams;
 
+  const actionGroupsWithConditions = actionGroups.map((actionGroup) =>
+    Number.isInteger(thresholds[actionGroup.id as AlwaysFiringActionGroupIds])
+      ? {
+          ...actionGroup,
+          conditions: thresholds[actionGroup.id as AlwaysFiringActionGroupIds]!,
+        }
+      : actionGroup
+  );
+
   return (
     <Fragment>
       <EuiFlexGroup gutterSize="s" wrap direction="column">
@@ -96,14 +105,7 @@ export const AlwaysFiringExpression: React.FunctionComponent<AlertTypeParamsExpr
         <EuiFlexItem grow={true}>
           <AlertConditions
             headline={'Set different thresholds for randomly generated T-Shirt sizes'}
-            actionGroups={actionGroups.map((actionGroup) =>
-              Number.isInteger(thresholds[actionGroup.id as AlwaysFiringActionGroupIds])
-                ? {
-                    ...actionGroup,
-                    conditions: thresholds[actionGroup.id as AlwaysFiringActionGroupIds]!,
-                  }
-                : actionGroup
-            )}
+            actionGroups={actionGroupsWithConditions}
             onInitializeConditionsFor={(actionGroup) => {
               setAlertParams('thresholds', {
                 ...thresholds,