2.1.0 #3
Merged
2.1.0 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some things are incredibly broken. Basically rewriting a lot of the code to work asynchronously. SQL was rewritten for smaller functions, scanning is now asynchronous (should be anyways). Compacted Slackbot a little bit, also changes icon based on number of servers down (once I've fixed all the other bugs :D).
Decided to nix async (for now) because I have no clue how to properly implement it. Instead decided to use threading, which should work just fine (benchmarks TBD). Also fixed SQL.py not commiting to the database (derp).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a better scanning script, completely rewrote the SQL script and also tweaked the Slackbot for more "fun" messages.
Threading should be much more effective as well.