Remove Type::Array variant #62
Conversation
|
Bump! |
|
For some reason I thought you weren't done since it was so tiny compared to the previous removals! Looks good, merge if it is indeed done! |
|
Oops, sec noticed a mistake. |
| @@ -139,14 +139,9 @@ impl<'a> KindCheck<'a> { | |||
| Ok((gen.kind.clone(), Type::generic(gen))) | |||
| } | |||
| Type::Variable(_) => panic!("kindcheck called on variable"), | |||
| Type::Builtin(BuiltinType::Array) | | |||
There was a problem hiding this comment.
Array and function do not have the same kind (Type -> Type vs Type -> Type -> Type). If you can add a test to catch this as well that would be great!
brendanzab
force-pushed
the
remove_type_array
branch
from
9a1e22b
to
988ac27
Compare
|
Fixed the array kind issue, but still need to do some tests. Should there be a separate kindcheck test module? |
|
There probably should be a separate kind check module. Currently the tests are just dumped into a single file (did split them into pass and fail in #61 though) |
|
arrrg skeptic arrg! (rebuilding) |
|
It might be that travis_wait is messing it up, gonna run some builds on travis in #66 |
|
@bjz Should this be merged? Or are you working on adding a kindcheck test? |
# Conflicts: # check/src/typecheck.rs
|
Yeah - would be nice to merge it - won't have much time to do stuff on gluon this week. Maybe we should make an issue to add a test... |
|
Ok, I think its fine to merge it. Opening an issue for adding kindcheck tests would be a good idea. |
Working towards #50