Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Low Latency playlists with omitted LAST-MSN #382

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

bbayles
Copy link
Contributor

@bbayles bbayles commented Sep 24, 2024

I encountered this stream in the wild. Its rendition reports are missing the LAST-MSN attribute, which causes an error with m3u8.

The spec says:

The value is a decimal-integer specifying the Media Sequence
      Number of the last Media Segment currently in the specified
      Rendition.  If the Rendition contains Partial Segments then this
      value is the Media Sequence Number of the last Partial Segment.
      This attribute is REQUIRED.

But then it says:

   A server MAY omit adding an attribute to an EXT-X-RENDITION-REPORT
   tag - even a mandatory attribute - if its value is the same as that
   of the Rendition Report of the Media Playlist to which the EXT-X-
   RENDITION-REPORT tag is being added.  Doing so reduces the size of
   the Rendition Report.

Therefore it can be valid to leave it out, so m3u8 is being too restrictive. I've fixed the issue in this PR.

@mauricioabreu
Copy link
Member

Awesome work @bbayles
thank you and sorry for the late review.

@mauricioabreu mauricioabreu merged commit 1108edc into globocom:master Oct 3, 2024
8 checks passed
@bbayles bbayles deleted the ll-rendition-report branch October 3, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants