Issue #373: Import EXT-X-CUE-OUT and EXT-X-CUE-OUT-CONT handling #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbayles
commented
Jul 30, 2024
| name, value = param.split("=", 1) | ||
| name = normalize_attribute(name) | ||
| param_parts = param.split("=", 1) | ||
| if len(param_parts) == 1: |
There was a problem hiding this comment.
This change affects all tags - if there's some parameter without a key=value pair, it will get stuck into the empty string key.
bbayles
commented
Jul 30, 2024
| @@ -273,7 +281,7 @@ def test_segment_envivio_scte35_attribute(): | |||
| def test_segment_unknown_scte35_attribute(): | |||
| obj = m3u8.M3U8(playlists.CUE_OUT_INVALID_PLAYLIST) | |||
| assert obj.segments[0].scte35 is None | |||
| assert obj.segments[0].scte35_duration is None | |||
| assert obj.segments[0].scte35_duration == "INVALID" | |||
There was a problem hiding this comment.
We now no longer assume a particular format for duration, so weird fraction stuff can flow through.
mauricioabreu
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the handling for
EXT-X-CUE-OUTandEXT-X-CUE-OUT-CONTtags.Previously the parsers for these tags attempted to understand a few different vendor formats, but I've tried to simplify things to avoid crashing when novel ones are encountered.
Closes #373