[FEAT] Implement Glimmer Components RFC #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
feat/implement-glimmer-components-rfc
branch
from
7a3a716
to
ce21812
Compare
pzuraq
changed the title
pzuraq
force-pushed
the
feat/implement-glimmer-components-rfc
branch
from
ce21812
to
7f515d6
Compare
pzuraq
force-pushed
the
feat/implement-glimmer-components-rfc
branch
2 times, most recently
from
8e51bd0
to
2325a21
Compare
|
Tested in both a Glimmer.js and Ember.js app generated using the default blueprints. The Glimmer.js app was hard to test, due to the way the application pipeline works for it. I ended up having to actually copy/paste the dist into |
tomdale
reviewed
Feb 6, 2019
| CI: !!process.env.CI | ||
| } | ||
| }, | ||
| [require.resolve('babel-plugin-debug-macros'), { |
There was a problem hiding this comment.
Were the changes in this file needed for Ember compatibility, or just general cleanup?
There was a problem hiding this comment.
Something happened as I was upgrading that caused the babel-plugin-debug-macros options have changed deprecation message to start popping up everywhere, so I figured it would be good to clean it up and update.
pzuraq
force-pushed
the
feat/implement-glimmer-components-rfc
branch
from
f063467
to
21e30eb
Compare
This PR turns the `@glimmer/component` package into an Ember addon, allowing it to work in both Ember.js and Glimmer.js applications. This works by keeping the `GlimmerComponent` class definition in a separate file that then gets imported by the Glimmer.js implementation in `src`, and is included in the Ember.js implementation via `addon/index.js`.
pzuraq
force-pushed
the
feat/implement-glimmer-components-rfc
branch
from
21e30eb
to
5ec0400
Compare
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns the
@glimmer/componentpackage into an Ember addon, allowing it to work in both Ember.js and Glimmer.js applications. This works by keeping theGlimmerComponentclass definition in a separate file that then gets imported by the Glimmer.js implementation insrc, and is included in the Ember.js implementation viaaddon/index.js.Notes:
@glimmer/di, it wants to be able to inject things universally but that is not allowed in the final design forGlimmerComponent. When we receive aComponentFactory, we pull the class definition off it and use it directly instead.@glimmer/blueprintdoesn't need to be treated too specially anymore, it just gets ignored by the packaging step so we don't build an emptydist.