Ensure loc is populated by builders.element(...)
#1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issues with AST transforms that were previously not passing `loc` in the `builders.element` options.
lifeart
approved these changes
Nov 19, 2020
jamescdavis
approved these changes
Nov 19, 2020
pzuraq
approved these changes
Nov 19, 2020
rwjblue
added a commit
to emberjs/ember.js
that referenced
this pull request
Nov 20, 2020
Includes the following bugfixes: * [#1209](glimmerjs/glimmer-vm#1209) Ensure `<output form="some-value">` works properly * [#1205](glimmerjs/glimmer-vm#1205) Ensure `@tracked` assertion can be made a deprecation * [#1204](glimmerjs/glimmer-vm#1204) Ensure `loc` is populated by `build ers.element(...)` Changelog here: https://github.com/glimmerjs/glimmer-vm/releases/tag/v0.66.1
sly7-7
pushed a commit
to sly7-7/ember.js
that referenced
this pull request
Mar 10, 2021
Includes the following bugfixes: * [emberjs#1209](glimmerjs/glimmer-vm#1209) Ensure `<output form="some-value">` works properly * [emberjs#1205](glimmerjs/glimmer-vm#1205) Ensure `@tracked` assertion can be made a deprecation * [emberjs#1204](glimmerjs/glimmer-vm#1204) Ensure `loc` is populated by `build ers.element(...)` Changelog here: https://github.com/glimmerjs/glimmer-vm/releases/tag/v0.66.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with AST transforms that were previously not passing
locin thebuilders.elementoptions.Many AST transform based builders exist, and not all of them thread through a
locproperty. Some examples:https://github.com/DockYard/ember-maybe-in-element/blob/68067d0cb45554db309af540f4c5e8754c90c742/lib/ast-transform.js#L28-L34
https://github.com/DockYard/ember-maybe-in-element/blob/68067d0cb45554db309af540f4c5e8754c90c742/lib/ast-transform.js#L38-L42
https://github.com/ember-template-lint/ember-template-recast/blob/7ad3aec371df48a76907a743779b0fa5cac97b39/src/parse-result.test.ts#L11
https://github.com/ember-template-lint/ember-template-recast/blob/7ad3aec371df48a76907a743779b0fa5cac97b39/src/parse-result.test.ts#L234-L248
Should fix cibernox/ember-basic-dropdown#586