Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for floats with scientific notation #1903

Merged
merged 3 commits into from
Dec 22, 2022
Merged

Add support for floats with scientific notation #1903

merged 3 commits into from
Dec 22, 2022

Conversation

bookshelfdave
Copy link

@bookshelfdave bookshelfdave commented Dec 20, 2022 •
edited

@bookshelfdave bookshelfdave force-pushed the dp_scientific_notation branch 2 times, most recently from 2541f08 to 471703c Compare December 21, 2022 21:38
@bookshelfdave bookshelfdave marked this pull request as ready for review December 21, 2022 21:43
inoas
inoas reviewed Dec 21, 2022
View reviewed changes
compiler-core/src/erlang/tests/numbers.rs Show resolved Hide resolved
test/language/src/main.gleam Outdated Show resolved Hide resolved
lpil
lpil reviewed Dec 21, 2022
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work! I've left a few small comments inline

compiler-core/src/javascript/tests/numbers.rs Outdated Show resolved Hide resolved
compiler-core/src/format/tests.rs Show resolved Hide resolved
compiler-core/src/parse/lexer.rs Show resolved Hide resolved
lpil
lpil approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you!

@lpil
Copy link
Member

lpil commented Dec 22, 2022

Oops, there's an indentation issue in the tests @bookshelfdave

@bookshelfdave
Copy link
Author

I left out a .snap file, I'll add and push in a moment.

@lpil lpil merged commit e8f0b21 into gleam-lang:main Dec 22, 2022
bookshelfdave pushed a commit to bookshelfdave/website that referenced this pull request Dec 26, 2022
Add scientific notation docs
77ebf61 
gleam-lang/gleam#1903
@bookshelfdave bookshelfdave mentioned this pull request Dec 26, 2022
Merged
lpil pushed a commit to gleam-lang/website that referenced this pull request Dec 26, 2022
@lpil
Add scientific notation docs
97b0a62 
gleam-lang/gleam#1903
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inoas inoas inoas left review comments

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bookshelfdave @lpil @inoas