-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-163: full support of NumPy v2
#207
base: main
Are you sure you want to change the base?
Conversation
Have had to drop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! But should this be 2 PRs? Or at least should be 2 separate CHANGELOG notes (dropping Python versions should go in breaking changes?)?
Yeah I guess the Python changes (#198) should be done first, then NumPy. I hadn't realised they were necessary at the time. |
AFAICT, this would make numpy v2 required, not merely compatible without deprecations. I find that a bit of a strong requirement when the code works perfectly well with numpy<2 as well. Why not conditionally import |
Yep, I had thought about that. I think this will become a piece of frustrating maintenance burden to be both API compatible, whilst still maintaining |
Fixes #163. Think the only change is required is
np.trapz
tonp.trapezoid
, verified with NPY201. Also fixes #189.