-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pick color in verteces #8
Conversation
surface = createSurface({ | ||
gl: gl, | ||
field: field, | ||
//levels: [contourLevels,contourLevels,contourLevels], | ||
lineWidth: 3, | ||
contourTint: 1, | ||
coords: coords, | ||
contourProject: [[true,false,false], [true,false,false], [true,false,false]] | ||
contourProject: [[true,false,false], [true,false,false], [true,false,false]], | ||
vertexColor: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a good idea, potentially with an obscure manual override.
Looks ok to me. |
Oh I fixed it:
@dfcreative can you make it such that no |
Nicely done. Your patch is backward compatible once #8 (comment) is addressed: |
@etpinard oh, sorry about that, fixed |
Great. It works. Let merge this in. |
Add vertex mode of picking color. Really not sure about the option name, if you have better idea than
vertexColor
I’ll rename it.