Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mouse-wheel (and the buggy to-px dependency) is abandoned, please replace #19

Open
vdh opened this issue May 30, 2019 · 6 comments
Open

Comments

@vdh
Copy link

vdh commented May 30, 2019

mouse-wheel has not been touched in 3 to 4 years, and to-px in 7 months, and this critical module loading bug has sat untouched since January: mikolalysenko/to-px#6

@archmoj Since it looks like it was added in c7f8316 could you please review this, and change to a different library for that mouse wheel dependency?

@vdh vdh changed the title mouse-wheel (and the buggy to-px dependancy) is abandoned, please replace mouse-wheel (and the buggy to-px dependency) is abandoned, please replace May 30, 2019
@archmoj
Copy link
Contributor

archmoj commented Jun 10, 2019

@vdh would you be interested to submit a PR to to-px?
cc: @etpinard

@vdh
Copy link
Author

vdh commented Jun 10, 2019

@archmoj I created a PR when I first noticed the issue: mikolalysenko/to-px#9
But then I noticed a very similar PR already created back on the 5th of February that didn't get a response: mikolalysenko/to-px#8
So at that point, I came to the conclusion that to-px has probably been abandoned. Or at the very least inactive for a very long time. I'm not sure how stable it is to rely on these libraries if they're not going to be maintained.

@archmoj
Copy link
Contributor

archmoj commented Jun 10, 2019

I don't think to-px is abandoned. According to npm @mikolalysenko did publish version 1.1.0 about 7 months ago (not 3/4 year ago). @vdh I encourage you to possibly follow up with one of those PRs; and once merged we can benefit from them here.
Thanks.

@vdh
Copy link
Author

vdh commented Jun 10, 2019

@archmoj 7 months is still quite a long time. How exactly am I supposed to "follow up" if he never responded to a PR from February for the same issue?

@archmoj
Copy link
Contributor

archmoj commented Jul 3, 2019

@etpinard this is similar to what we discussed in plotly/plotly.js#4009.
What about trying mikolalysenko/to-px#8 & mikolalysenko/to-px#9 patches?

@etpinard
Copy link
Member

etpinard commented Jul 3, 2019

Correct @archmoj - both mikolalysenko/to-px#8 and mikolalysenko/to-px#9 would have be sufficient to prevent the problems fixed in plotly/plotly.js#4009.

We could try to contact Mikola.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants