Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

チャンネルの取得 API のアップデート #66

Merged
merged 13 commits into from
Jun 27, 2024
Merged

チャンネルの取得 API のアップデート #66

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1abfc1d
[fix] api を修正 & serverId を取得
TakanoHori Jun 26, 2024
94e2644
[add] usecase の追加
TakanoHori Jun 26, 2024
6abb105
[add] interface get_channels_repository の追加
TakanoHori Jun 26, 2024
8089593
[refactoring] getChannelsRepository
TakanoHori Jun 26, 2024
b74b1be
[fix] serverId を引数にチャンネルを取得する関数を修正
TakanoHori Jun 26, 2024
29d6a5c
[fix] server_id を使ってチャンネルの検索をかける
TakanoHori Jun 26, 2024
a7c7b09
[fix] DB から name しか取ってないじゃんこれ！
TakanoHori Jun 26, 2024
65354c6
Merge branch 'main' into fix/get-channel-update
TakanoHori Jun 27, 2024
10146c5
[fix] 削除されていないチャンネルを取得する
TakanoHori Jun 27, 2024
6782b47
[fix] スネークケースに統一
TakanoHori Jun 27, 2024
0007048
Merge branch 'main' into fix/get-channel-update
TakanoHori Jun 27, 2024
9ac4e61
[fix] serverId
TakanoHori Jun 27, 2024
eacffe1
Merge branch 'main' into fix/get-channel-update
TakanoHori Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/timeline/internal/controllers/get_channel_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
)

func GetChannels(ctx *gin.Context) {
serverId, err := strconv.Atoi(ctx.Param("id"))
serverId, err := strconv.Atoi(ctx.Param("serverId"))
if err != nil {
ctx.JSON(http.StatusBadRequest, err.Error())
}
Expand Down
2 changes: 1 addition & 1 deletion backend/timeline/internal/middleware/router.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func SetupRoutes(app *gin.Engine) {
authorized.Use(Auth())
{
authorized.GET("/servers", controllers.GetServers)
authorized.GET("/servers/:id/channels", controllers.GetChannels)
authorized.GET("/servers/:serverId/channels", controllers.GetChannels)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

panic: ':serverId' in new path '/servers/:serverId/channels/:channelId/posts' conflicts with existing wildcard ':id' in existing prefix '/servers/:id'

投稿などで 2つ id を管理する場合、このエラーでこけることがあったため、分けられるようにする。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gin-gonic/gin#1301 (comment)

authorized.POST("/servers/:id/channels", controllers.CreateChannels)
authorized.GET("/channels/:id/posts", controllers.GetPosts)
authorized.POST("/channels/:id/posts", controllers.CreatePost)
Expand Down
Loading