Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set app version as dev when building locally #1237

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

setchy
Copy link
Member

@setchy setchy commented Jun 14, 2024

A small enhancement to help when doing local development remember which version of the app is running 😎

Screenshot 2024-06-14 at 9 39 24 AM

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Jun 14, 2024
@setchy setchy added this to the Release 5.9.0 milestone Jun 14, 2024
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Could also consider changing a key color, like the sidebar background, so it's hard to miss

@setchy setchy merged commit d288aa6 into main Jun 14, 2024
11 checks passed
@setchy setchy deleted the feature/dev-version branch June 14, 2024 16:08
@afonsojramos
Copy link
Member

Would also be nice to have "demo notifications" so that we don't need to load real ones 🤔

@setchy
Copy link
Member Author

setchy commented Jun 14, 2024

I have a stash locally that mocks the API response. Could add that into the scope of #980 or as a separate idea (probably better separately)

@setchy
Copy link
Member Author

setchy commented Jun 14, 2024

A while ago I was using https://github.com/setchy/gitify-notifications-sandbox too, which could be transferred into the gitify-app organization if we wanted "real" notifications

@afonsojramos
Copy link
Member

I suppose there's the two cases, the ones where we just want to work with UI, and the cases where we need to work with the flow themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants