Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back proper support for Ruby 3.x #901

Merged
merged 2 commits into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@ jobs:
strategy:
matrix:
ruby:
- '3.0'
- '3.3'
- 3.0
yoannchaudet marked this conversation as resolved.
Show resolved Hide resolved
- 3.1
- 3.2
- 3.3
yoannchaudet marked this conversation as resolved.
Show resolved Hide resolved
steps:
- uses: actions/checkout@v4
- name: script/cibuild-docker
Expand Down
3 changes: 0 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ RUN apt-get update \
make \
nodejs

# final version for rubygems-update to supoprt ruby 2.7, consider removing this after upgraded to ruby 3.0
RUN gem update --system

COPY .git /src/gh/pages-gem/.git
COPY Gemfile* /src/gh/pages-gem/
COPY github-pages.gemspec /src/gh/pages-gem
Expand Down
2 changes: 1 addition & 1 deletion lib/github-pages/dependencies.rb
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def self.version_report
require "nokogiri"

{
"ruby" => "3.3",
"ruby" => RUBY_VERSION,

# Gem versions we're curious about
"github-pages" => VERSION.to_s,
Expand Down