Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add team assignment #63

Merged
merged 1 commit into from
Jul 21, 2023
Merged

docs: Add team assignment #63

merged 1 commit into from
Jul 21, 2023

Conversation

zkoppert
Copy link
Member

fixes #52

@zkoppert zkoppert self-assigned this Jul 21, 2023
@zkoppert zkoppert added the documentation Improvements or additions to documentation label Jul 21, 2023
@zkoppert zkoppert merged commit 580a22b into main Jul 21, 2023
4 checks passed
@zkoppert zkoppert deleted the teams branch July 21, 2023 19:25
@julioz
Copy link

julioz commented Jul 21, 2023

Thanks. An important part we're missing here is that the GitHub Action machine account must have the permissions to read the organizations' teams and their members. Without it, jq will take an empty list as input (gh api outputs nothing to stdout).

@zkoppert
Copy link
Member Author

@julioz I don't see organization team members as an option in the list of permissions to assign. Do you know how to assign this? Maybe we need a step to use a custom token to auth into the gh api tool. I can ask around here as well.

@julioz
Copy link

julioz commented Jul 21, 2023

Yep precisely, the token needs to be generated with these permissions and set as a repository secret.

@zkoppert
Copy link
Member Author

zkoppert commented Jul 21, 2023

I see now, we should just change GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} to be GITHUB_TOKEN: ${{ secrets.CUSTOM_API_TOKEN }} and give instructions for how to create a token and what permissions. I'll work on that.

@zkoppert
Copy link
Member Author

#64 to update the documentation. Thanks for the heads up on this! Feel free to review the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign members of a GitHub team handle in addition of individuals
2 participants