Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch error that occurs when ghost usre creates an event. #325

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

zkoppert
Copy link
Member

Pull Request

fixes #322

Proposed Changes

This pull request changes the get_time_to_ready_for_review function in the time_to_ready_for_review.py file. The change introduces error handling to deal with potential TypeError exceptions that might occur when processing review events. If such an error occurs, a message is printed to inform the user that the issue might contain a ghost user, and None is returned.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

Signed-off-by: Zack Koppert <zkoppert@github.com>
@zkoppert zkoppert merged commit 2af47be into main Jun 25, 2024
26 checks passed
@zkoppert zkoppert deleted the catch-type-error branch June 25, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: 'NoneType' object is not subscriptable
2 participants