Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for measuring discussions #32

Merged
merged 9 commits into from
Jun 27, 2023
Merged

Allow for measuring discussions #32

merged 9 commits into from
Jun 27, 2023

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Jun 22, 2023

This pull request allows this action to measure discussion metrics by including type:discussion in the search query. Adding discussions also enables the measurement of the time to answer metric. This will be a breaking change since the .env file has entries removed and so version numbers should roll to 2.0.0.

Tasks:

  • Enable the new metric of time to answer
  • Wire up existing metrics to handle discussions
  • Configure the action to allow for measuring org discussions that are not tied to a repo. Currently this is configured to act on a single repository since issues and pull requests are associated with a repository.
  • Update documentation
  • Write new tests for the new functions
  • Update existing tests for changes to existing functions like write_markdown()

fixes #31

Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
@zkoppert zkoppert self-assigned this Jun 22, 2023
@zkoppert zkoppert added the enhancement New feature or request label Jun 22, 2023
Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
@zkoppert zkoppert added documentation Improvements or additions to documentation breaking labels Jun 23, 2023
Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
@zkoppert zkoppert marked this pull request as ready for review June 24, 2023 06:30
@zkoppert
Copy link
Member Author

Test coverage isn't perfect but its nearly 90%. I'll call that good enough for now and improve later.

@zkoppert
Copy link
Member Author

Still need to merge, bump to v2.0.0 and release. I'm out of office on Monday, so will likely get back to this on Tuesday,

@zkoppert zkoppert merged commit 28ecd14 into main Jun 27, 2023
4 checks passed
@zkoppert zkoppert deleted the discussions branch June 27, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Measuring discussions
1 participant