chore: readable and pythonic logic

Co-authored-by: jmeridth <jmeridth@gmail.com>
github · Jun 11, 2024 · a987f81 · a987f81
1 parent 5e6d889
commit a987f81
Showing 1 changed file with 11 additions and 11 deletions.
diff --git a/issue_metrics.py b/issue_metrics.py
@@ -193,10 +193,10 @@ def get_per_issue_metrics(
                 )
             if env_vars.hide_time_to_answer is False:
                 issue_with_metrics.time_to_answer = measure_time_to_answer(issue)
-            if env_vars.hide_time_to_close is False and issue["closedAt"]:
-                issue_with_metrics.time_to_close = measure_time_to_close(None, issue)
             if issue["closedAt"]:
                 num_issues_closed += 1
+                if not env_vars.hide_time_to_close:
+                    issue_with_metrics.time_to_close = measure_time_to_close(None, issue)
             else:
                 num_issues_open += 1
         else:
@@ -234,17 +234,17 @@ def get_per_issue_metrics(
                 )
             if labels and env_vars.hide_label_metrics is False:
                 issue_with_metrics.label_metrics = get_label_metrics(issue, labels)
-            if env_vars.hide_time_to_close is False and issue.state == "closed":  # type: ignore
-                if pull_request:
-                    issue_with_metrics.time_to_close = measure_time_to_merge(
-                        pull_request, ready_for_review_at
-                    )
-                else:
-                    issue_with_metrics.time_to_close = measure_time_to_close(
-                        issue, None
-                    )
             if issue.state == "closed":  # type: ignore
                 num_issues_closed += 1
+                if not env_vars.hide_time_to_close:
+                    if pull_request:
+                        issue_with_metrics.time_to_close = measure_time_to_merge(
+                            pull_request, ready_for_review_at
+                        )
+                    else:
+                        issue_with_metrics.time_to_close = measure_time_to_close(
+                            issue, None
+                        )
             elif issue.state == "open":  # type: ignore
                 num_issues_open += 1
         issues_with_metrics.append(issue_with_metrics)