Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected documentation #31025

Merged
merged 8 commits into from
Jan 22, 2024
Merged

Corrected documentation #31025

merged 8 commits into from
Jan 22, 2024

Conversation

C0derPr0
Copy link
Contributor

@C0derPr0 C0derPr0 commented Jan 10, 2024

Why:

Step 1 for the section "Configuring ReSharper for GitHub Copilot" and the associated image was incorrect.

Closes: 31013

What's being changed (if available, include any code snippets, screenshots, or gifs):

I changed the incorrect content under the section "Configuring Resharper for GitHub Copilot."

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Copy link

welcome bot commented Jan 10, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 10, 2024
Copy link
Contributor

github-actions bot commented Jan 10, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
copilot/configuring-github-copilot/configuring-github-copilot-in-your-environment.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review copilot Content related to GitHub Copilot and removed triage Do not begin working on this issue until triaged by the team labels Jan 10, 2024
@nguyenalex836
Copy link
Contributor

@C0derPr0 Thanks so much for opening a PR! I'll get this triaged for review ✨

Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@C0derPr0 - Many thanks for raising the docs issue, and this PR. 🎖️

I've made a couple of little suggestions which you can click to commit.

Thanks for including a screenshot but I don't think it's necessary here, and we've recently been trying to cut down on unnecessary screenshots in the docs. Could you delete the screenshot file from this PR? Thanks

C0derPr0 and others added 4 commits January 19, 2024 13:19
@C0derPr0 C0derPr0 closed this Jan 19, 2024
@C0derPr0 C0derPr0 reopened this Jan 19, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 19, 2024
@C0derPr0
Copy link
Contributor Author

Sorry to be a bother..., but it says, "Merging is blocked until requested changes are addressed." I committed the requested changes, so I don't know why it is blocked.

@nguyenalex836
Copy link
Contributor

@C0derPr0 Thanks for letting us know! @hubwriter may need to re-review after the suggestions have been committed, and I've just requested a re-review from him 💛

@nguyenalex836 nguyenalex836 removed the triage Do not begin working on this issue until triaged by the team label Jan 19, 2024
@hubwriter
Copy link
Contributor

Hi @C0derPr0 - thanks for making those changes.

Can you delete resharper-toolbar-options.png from your branch? Then I'll get this merged.

@C0derPr0
Copy link
Contributor Author

@hubwriter Okay, I deleted the image. Sorry about that, I committed your requested change several days ago and thought that included deleting the image.

Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@C0derPr0 - Great. Thanks for the quick response.

I'll get this merged now. Many thanks for helping with the docs. Much appreciated. 👍

@hubwriter hubwriter added this pull request to the merge queue Jan 22, 2024
Merged via the queue into github:main with commit 4ea2302 Jan 22, 2024
41 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team copilot Content related to GitHub Copilot waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Documentation: Configuring Resharper
3 participants