-
Notifications
You must be signed in to change notification settings - Fork 59.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected documentation #31025
Corrected documentation #31025
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@C0derPr0 Thanks so much for opening a PR! I'll get this triaged for review ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@C0derPr0 - Many thanks for raising the docs issue, and this PR. 🎖️
I've made a couple of little suggestions which you can click to commit.
Thanks for including a screenshot but I don't think it's necessary here, and we've recently been trying to cut down on unnecessary screenshots in the docs. Could you delete the screenshot file from this PR? Thanks
content/copilot/configuring-github-copilot/configuring-github-copilot-in-your-environment.md
Outdated
Show resolved
Hide resolved
content/copilot/configuring-github-copilot/configuring-github-copilot-in-your-environment.md
Outdated
Show resolved
Hide resolved
…copilot-in-your-environment.md Co-authored-by: hubwriter <hubwriter@github.com>
…copilot-in-your-environment.md Co-authored-by: hubwriter <hubwriter@github.com>
Sorry to be a bother..., but it says, "Merging is blocked until requested changes are addressed." I committed the requested changes, so I don't know why it is blocked. |
@C0derPr0 Thanks for letting us know! @hubwriter may need to re-review after the suggestions have been committed, and I've just requested a re-review from him 💛 |
Hi @C0derPr0 - thanks for making those changes. Can you delete resharper-toolbar-options.png from your branch? Then I'll get this merged. |
@hubwriter Okay, I deleted the image. Sorry about that, I committed your requested change several days ago and thought that included deleting the image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@C0derPr0 - Great. Thanks for the quick response.
I'll get this merged now. Many thanks for helping with the docs. Much appreciated. 👍
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Step 1 for the section "Configuring ReSharper for GitHub Copilot" and the associated image was incorrect.
Closes: 31013
What's being changed (if available, include any code snippets, screenshots, or gifs):
I changed the incorrect content under the section "Configuring Resharper for GitHub Copilot."
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.