Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: augment test-extraction tests #17637

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Oct 1, 2024

This adds a case exercising the need for packages to be visited in topological order (cross-package type variable references), and a _test package that wouldn't exist in go list output without the -test flag. Unfortunately I couldn't reproduce the circumstance where that causes a crash, but by instrumenting the code that invokes go list I can see that with the -test flag we get everything we need out of one go list run, whereas without it we fall back to the slow path that issues individual go list queries on a per package basis.

@smowton smowton requested a review from a team as a code owner October 1, 2024 17:28
@github-actions github-actions bot added the Go label Oct 1, 2024
@smowton smowton requested review from owen-mc and mbg October 2, 2024 15:45
@smowton smowton merged commit 321eb34 into github:main Oct 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants