Go: augment test-extraction tests #17637
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a case exercising the need for packages to be visited in topological order (cross-package type variable references), and a
_test
package that wouldn't exist ingo list
output without the-test
flag. Unfortunately I couldn't reproduce the circumstance where that causes a crash, but by instrumenting the code that invokesgo list
I can see that with the-test
flag we get everything we need out of onego list
run, whereas without it we fall back to the slow path that issues individualgo list
queries on a per package basis.