Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CLI SARIF merge feature flag #2271

Merged
merged 1 commit into from
May 3, 2024

Conversation

koesie10
Copy link
Member

@koesie10 koesie10 commented May 3, 2024

This feature flag is fully enabled, so it can be removed. There is still a tool feature check, so it still won't change anything on older CodeQL versions (except for printing a "The CodeQL CLI does not support merging SARIF files. Merging files in the action." warning).

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@koesie10 koesie10 marked this pull request as ready for review May 3, 2024 13:57
@koesie10 koesie10 requested a review from a team as a code owner May 3, 2024 13:57
@koesie10 koesie10 merged commit 84d6ead into main May 3, 2024
639 checks passed
@koesie10 koesie10 deleted the koesie10/remove-cli-sarif-merge-ff branch May 3, 2024 14:40
@github-actions github-actions bot mentioned this pull request May 8, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants