Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @types/node to bottom of devDependencies #2213

Closed
wants to merge 2 commits into from

Conversation

aeisenberg
Copy link
Contributor

This will make it less likely for a dependabot update to cause conflicts when backporting from v3 -> v2. It's a little clunky, but should probably work.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

This will make it less likely for a dependabot update to cause conflicts
when backporting from v3 -> v2.
@aeisenberg aeisenberg requested a review from a team as a code owner March 26, 2024 20:12
@angelapwen
Copy link
Contributor

Looks like the dependencies check is failing.. let me add the update dependencies label and see if it changes package-lock.json.

@angelapwen angelapwen added the Update dependencies Trigger PR workflow to update dependencies label Mar 26, 2024
@github-actions github-actions bot removed the Update dependencies Trigger PR workflow to update dependencies label Mar 26, 2024
Copy link
Contributor

Pushed a commit to update the checked-in dependencies. Please mark the PR as ready for review to trigger PR checks.

@github-actions github-actions bot marked this pull request as draft March 26, 2024 20:58
@aeisenberg
Copy link
Contributor Author

Yeah...this approach won't work. It's failing because we recreate the package.json and check to see if there are any differences with what is checked in. And there always will be since the way we recreate the package.json file, the dependencies are sorted alphabetically.

@angelapwen
Copy link
Contributor

Ok, don't think this will work unfortunately 😢

@aeisenberg aeisenberg closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants