Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add announcement on Node 16 deprecation #1960

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

angelapwen
Copy link
Contributor

Make the announcement in the issue visible via the Action changelog and the README.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@angelapwen angelapwen requested a review from a team as a code owner October 18, 2023 21:19
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

One more suggestion. Can we detect when this warning is emitted and emit a second warning pointing to the issue for more information (only if the original warning is also emitted)?

@angelapwen
Copy link
Contributor Author

Thanks!

One more suggestion. Can we detect when this warning is emitted and emit a second warning pointing to the issue for more information (only if the original warning is also emitted)?

Hm.. that's an interesting idea. I'm not sure actually, I think it will be more clear once the warning is actually emitted. But so far I don't think we've used a mechanism to catch underlying Actions warnings.

@aeisenberg
Copy link
Contributor

After the warning starts being emitted, it will be emitted for every workflow run? If so, we can wait until it's emitted and then include a custom warning that links to the issue.

@angelapwen
Copy link
Contributor Author

After the warning starts being emitted, it will be emitted for every workflow run? If so, we can wait until it's emitted and then include a custom warning that links to the issue.

Yes, I think so — at least that's what I understood from the Changelog post: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

@angelapwen angelapwen enabled auto-merge (squash) October 18, 2023 21:51
@angelapwen angelapwen merged commit 4a368f6 into github:main Oct 18, 2023
330 checks passed
@github-actions github-actions bot mentioned this pull request Oct 20, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants